Changeset 193 for trunk/docx4j/src/main/java/org/docx4j/openpackaging/packages/WordprocessingMLPackage.java

Timestamp:

03/15/08 06:11:00 (4 years ago)

Author:

jharrop

Message:

Workaround for docx4all java.util.prefs.FileSystemPreferences? syncWorld, WARNING: Couldn't flush user prefs: java.util.prefs.BackingStoreException?: java.lang.IllegalArgumentException?: Not supported: indent-number, every 30 seconds, caused by use of Xalan (non xsltc).

File:

• trunk/docx4j/src/main/java/org/docx4j/openpackaging/packages/WordprocessingMLPackage.java (modified) (2 diffs)

trunk/docx4j/src/main/java/org/docx4j/openpackaging/packages/WordprocessingMLPackage.java

@@ -259 +259 @@
                   net.sf.saxon.TransformerFactoryImpl
                   
+                HOWEVER, docx4all encounters http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6396599
+                
+                        java.util.prefs.FileSystemPreferences syncWorld
+                        WARNING: Couldn't flush user prefs: java.util.prefs.BackingStoreException: java.lang.IllegalArgumentException: Not supported: indent-number
+                
+                every 30 seconds
+
+                The workaround implemented is to remove META-INF/services from the xalan jar 
+                to prevent xalan being picked up as the default provider for jaxp transform,
+                so we have to use it explicitly.
+                
+                .. which means 
+
+                        System.setProperty("javax.xml.transform.TransformerFactory", "org.apache.xalan.processor.TransformerFactoryImpl");
+
                   (unfortunately, there is no com.sun.org.apache.xalan.processor.TransformerFactoryImpl,
                    so we have to bundle xalan jar, which is 2.7 MB
@@ -269 +284 @@
           That gets us from 2.7 MB to 1.85 MB.
           
-          But Sun already has:
+          Sun already has:
           
                         com.sun.org.apache.xpath;                       
                         com.sun.org.apache.xml.internal.dtm;                    
-                        com.sun.org.apache.xalan.internal.extensions|lib|res|templates
+                        com.sun.org.apache.xalan.internal.extensions|lib|res
                    
-                  So why not refactor Xalan and leave all that out as well?
+                  so you might think we can refactor Xalan to point to those, and them out of our jar.
                   
+                  well, it turns out that its too messy leaving out org.apache.xpath or xalan.extensions         
                   
-                HOWEVER, docx4all encounters http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6396599
-                
-                        java.util.prefs.FileSystemPreferences syncWorld
-                        WARNING: Couldn't flush user prefs: java.util.prefs.BackingStoreException: java.lang.IllegalArgumentException: Not supported: indent-number
-                
-                every 30 seconds
-
-                The workaround implemented is to remove META-INF/services from the xalan jar 
-                to prevent xalan being picked up as the default provider for jaxp transform,
-                so we have to use it explicitly.
-                
-                .. which means 
-
-                        System.setProperty("javax.xml.transform.TransformerFactory", "org.apache.xalan.processor.TransformerFactoryImpl");
+                  so you have to keep xalan.extensions, processor, serialize, trace, transformer
+
+                  leaving out just org.apache.xalan.resources and org.apache.xpath.resources
+                  only gets us down to 1.5 MB. (and that's with just jar cvf xalan-minimal.jar org/apache/xalan org/apache/xpath
+                        - we'd still need to include org/apache/xml)
+                        
+                        ie once you include the whole of org.apache.xpath, you may as well just go with the 1.85 MB  :(
                         
 */              
-                
                 
                 javax.xml.transform.TransformerFactory tfactory = javax.xml.transform.TransformerFactory.newInstance();